Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SORT_RO #1858

Merged
merged 5 commits into from
Mar 14, 2022
Merged

Add support for SORT_RO #1858

merged 5 commits into from
Mar 14, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jan 5, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #1809

@dvora-h dvora-h added feature New feature redis-7 labels Jan 5, 2022
@dvora-h dvora-h requested a review from chayim January 5, 2022 10:56
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022 •
edited
Loading

Codecov Report

Merging #1858 (eee810f) into master (9442d34) will decrease coverage by 0.88%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1858      +/-   ##
==========================================
- Coverage   93.02%   92.13%   -0.89%     
==========================================
  Files          76      100      +24     
  Lines       16537    21009    +4472     
==========================================
+ Hits        15383    19356    +3973     
- Misses       1154     1653     +499
Impacted Files Coverage Δ
redis/commands/core.py 85.82% <63.15%> (-4.34%) ⬇️
tests/test_commands.py 98.76% <100.00%> (-0.64%) ⬇️
tests/test_command_parser.py 94.23% <0.00%> (-5.77%) ⬇️
redis/commands/timeseries/__init__.py 94.73% <0.00%> (-5.27%) ⬇️
tests/conftest.py 87.60% <0.00%> (-2.50%) ⬇️
redis/commands/json/__init__.py 97.56% <0.00%> (-2.44%) ⬇️
redis/commands/parser.py 88.40% <0.00%> (-1.92%) ⬇️
redis/cluster.py 91.93% <0.00%> (-0.50%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9442d34...eee810f. Read the comment docs.

@chayim
Copy link
Contributor

chayim commented Jan 27, 2022

@dvora-h mind taking a look at the cluster tests?

chayim
chayim reviewed Mar 14, 2022
View reviewed changes
redis/commands/core.py
Returns the elements contained in the list, set or sorted set at key.
(read-only variant of the SORT command)

``start`` and ``num`` allow for paging through the sorted data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do start and num come from? I dont't see them on the docs page. I see a LIMIT in which case we can align with the command.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it this way to stay consistent with 'sort', I can change both but I don't think it's a good idea

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I wish sort didn't look this way now. Fine - better to have two behave the same.

@chayim chayim self-requested a review March 14, 2022 13:46
@dvora-h dvora-h merged commit 4b22476 into redis:master Mar 14, 2022
@dvora-h dvora-h deleted the add-sort-ro branch May 9, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chayim chayim chayim approved these changes

Assignees
No one assigned
Labels
feature New feature redis-7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for SORT_RO
3 participants
@dvora-h @codecov-commenter @chayim